Skip to content

Detect orig.Invoke() and orig?.Invoke() for CL0003#1

Open
JaThePlayer wants to merge 1 commit into
EverestAPI:masterfrom
JaThePlayer:detect_orig_Invoke
Open

Detect orig.Invoke() and orig?.Invoke() for CL0003#1
JaThePlayer wants to merge 1 commit into
EverestAPI:masterfrom
JaThePlayer:detect_orig_Invoke

Conversation

@JaThePlayer

@JaThePlayer JaThePlayer commented Jul 28, 2025

Copy link
Copy Markdown
Member

Previously, these two ways to invoke orig would trigger CL0003, warning about not calling orig on any codepath , even though it is called:

using var detour4 = new Hook(..., static (Action<int> orig, int arg) => {
  orig.Invoke(arg);
});
            
using var detour5 = new Hook(..., static (Action<int> orig, int arg) =>  {
  orig?.Invoke(arg);
});```

microlith57
microlith57 approved these changes Jun 9, 2026
View reviewed changes
Comment thread CelesteAnalyzer/CelesteAnalyzer/HookAnalyzer.cs
Comment on lines +165 to +167
{
return true;
}

@microlith57 microlith57 Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: why is the block necessary? why not:

Suggested change
{
return true;
}
return true;

Comment thread CelesteAnalyzer/CelesteAnalyzer/HookAnalyzer.cs
Comment on lines +176 to +178
{
return true;
}

@microlith57 microlith57 Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

Suggested change
{
return true;
}
return true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microlith57 microlith57 microlith57 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaThePlayer @microlith57